Error on 404 #277
Merged
Error on 404 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test case
dom96
requested changes
Oct 7, 2021
This is by design in puppy as shown in the readme. I have left a question though in the puppy repo asking if the exceptions could be thrown when using the basic proc (treeform/puppy#31) |
dom96
requested changes
Oct 8, 2021
… sense when used in other areas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the
Responseobjects http code and returns error if 404 instead of writing an empty tar file and trying to extract that.Right now it only checks for 404, should it return an error unless the http code is 2xx?