can use status w/o quotes for insert statement #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Oct 1, 2021
go/vt/sqlparser/parse_test.go
Outdated
| @@ -2639,6 +2639,10 @@ func TestKeywords(t *testing.T) { | |||
| }, { | |||
| input: "select /* unused keywords as cols */ write, virtual from t where trailing = 'foo'", | |||
| output: "select /* unused keywords as cols */ `write`, `virtual` from t where `trailing` = 'foo'", | |||
| }, { | |||
| input: "insert into x (status) values (42)", | |||
There was a problem hiding this comment.
Add a test for update and delete too, bet one of them has the same issue.
Also you or Vinai should expand the reserved word test you wrote to include updates, deletes, inserts
max-hoffman
commented
Oct 12, 2021
go/vt/sqlparser/parse_test.go
Outdated
Comment on lines
2646
to
2647
| input: "insert into x (status) values (42)", | ||
| output: "insert into x(`status`) values (42)", |
VinaiRachakonda
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: dolthub/dolt#2195