Skip to content

Parse NATURAL FULL JOIN #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelamayxie merged 2 commits into from
Jan 8, 2026
Merged

Parse NATURAL FULL JOIN #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf39f4
add and parse NaturalFullJoinStr
angelamayxie Jan 8, 2026
0f4b1cb
add test cases
angelamayxie Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/vt/sqlparser/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5511,6 +5511,7 @@ const (
NaturalJoinStr = "natural join"
NaturalLeftJoinStr = "natural left join"
NaturalRightJoinStr = "natural right join"
NaturalFullJoinStr = "natural full join"
FullOuterJoinStr = "full outer join"
)

Expand Down
57 changes: 47 additions & 10 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,19 +744,52 @@ var (
}, {
input: "select /* right outer join */ 1 from t1 right outer join t2 using (a)",
output: "select /* right outer join */ 1 from t1 right join t2 using (a)",
}, {
input: "select /* natural join */ 1 from t1 natural join t2",
}, {
input: "select /* natural left join */ 1 from t1 natural left join t2",
}, {
},
{
input: "select /* natural join */ 1 from t1 natural join t2",
output: "select /* natural join */ 1 from t1 natural join t2",
},
{
input: "select /* natural left join */ 1 from t1 natural left join t2",
output: "select /* natural left join */ 1 from t1 natural left join t2",
},
{
input: "select /* natural left outer join */ 1 from t1 natural left join t2",
output: "select /* natural left outer join */ 1 from t1 natural left join t2",
}, {
input: "select /* natural right join */ 1 from t1 natural right join t2",
}, {
},
{
input: "select /* natural right join */ 1 from t1 natural right join t2",
output: "select /* natural right join */ 1 from t1 natural right join t2",
},
{
input: "select /* natural right outer join */ 1 from t1 natural right join t2",
output: "select /* natural right outer join */ 1 from t1 natural right join t2",
}, {
},
{
input: "select * from t1 natural left join t2",
output: "select * from t1 natural left join t2",
},
{
input: "select * from t1 natural left outer join t2",
output: "select * from t1 natural left join t2",
},
{
input: "select * from t1 natural right join t2",
output: "select * from t1 natural right join t2",
},
{
input: "select * from t1 natural right outer join t2",
output: "select * from t1 natural right join t2",
},
{
input: "select * from t1 natural full join t2",
output: "select * from t1 natural full join t2",
},
{
input: "select * from t1 natural full outer join t2",
output: "select * from t1 natural full join t2",
},
{
input: "select /* full outer join */ * from a full outer join b on a.x = b.x",
}, {
input: "select /* full outer join */ * from a full join b on a.x = b.x",
Expand Down Expand Up @@ -3052,7 +3085,7 @@ var (
output: "alter table t alter column foo drop default",
}, {
input: "alter table t alter column foo drop default",
}, {
}, {
input: "alter table t modify value float(53) not null",
output: "alter table t modify column `value` (\n" +
"\t`value` float(53) not null\n" +
Expand Down Expand Up @@ -6130,6 +6163,10 @@ func TestInvalid(t *testing.T) {
input: "insert into t (a) values (1) returning",
err: "syntax error",
},
{
input: "select * from t1 natural invalid join t2",
err: "syntax error",
},
}

for _, tcase := range invalidSQL {
Expand Down
Loading