Skip to content

fix up constants for server cursor types and add a support for PARAMETER_COUNT_AVAILABLE cursor#421

Merged
jycor merged 2 commits intomainfrom
james/streaming
Jun 11, 2025
Merged

fix up constants for server cursor types and add a support for PARAMETER_COUNT_AVAILABLE cursor#421
jycor merged 2 commits intomainfrom
james/streaming

Conversation

@jycor
Copy link

@jycor jycor commented Jun 10, 2025

We were missing the PARAMETER_COUNT_AVAILABLE server cursor type when handling a COM_STMT_EXECUTE.
Oddly, it seems to behave as if there were no cursor.

MySQL Docs: https://dev.mysql.com/doc/dev/mysql-server/9.3.0/mysql__com_8h.html#a3e5e9e744ff6f7b989a604fd669977da
Fixes: dolthub/dolt#9313

@jycor jycor requested a review from zachmu as a code owner June 10, 2025 18:06
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jycor jycor merged commit 90a5898 into main Jun 11, 2025
4 checks passed
@jycor jycor deleted the james/streaming branch June 11, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility of streaming prepared statement responses with github.com/go-mysql-org/go-mysql

2 participants