Conversation
fulghum
approved these changes
May 30, 2025
fulghum
left a comment
There was a problem hiding this comment.
InjectedExpr gets a bit more complicated to use though. Seems like you could probably get away with adding OrderBy directly to InjectedExpr, too, and avoid the new type, but I understand having the type makes it convenient to switch on type. The biggest design point I can think of there is if we think we'll end up adding many more of these extensions, and if the extensions will have cases where we need an OrderBy and some other field that comes from a different extension type. That ends up getting messy with many similar types obviously.
Overall seems reasonable though, and it sounds like we want to revisit aggregation in the future as we better understand what Doltgres needs, so I'm on board.
Co-authored-by: Jason Fulghum <jason@dolthub.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.