Skip to content

Updates for binlog primary protocol#320

Merged
fulghum merged 5 commits intomainfrom
fulghum/com_binlog_prototype
Mar 25, 2024
Merged

Updates for binlog primary protocol#320
fulghum merged 5 commits intomainfrom
fulghum/com_binlog_prototype

Conversation

@fulghum
Copy link

@fulghum fulghum commented Mar 13, 2024 •
edited
Loading

  • Porting over more code from vitess.io/vitess – support for the COM_REGISTER_REPLICA command.
  • Fixing a bug in Vitess' deserialization of the COM_BINLOG_DUMP_GTID command.
  • Adding some String functions to help with debugging.
  • Exposing the ability to flush a connection's buffer, as a short-term workaround for needing to flush the buffer more frequently than at the end of the connection in order to support `COM_BINLOG_DUMP_GTID'.

@fulghum fulghum force-pushed the fulghum/com_binlog_prototype branch from 745dda0 to 05a7b47 Compare March 13, 2024 20:14
@fulghum fulghum marked this pull request as ready for review March 14, 2024 18:22
@fulghum fulghum requested a review from zachmu as a code owner March 14, 2024 18:22
zachmu
zachmu approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fulghum added 2 commits March 19, 2024 20:17
@fulghum
Adding parser support for SOURCE_AUTO_POSITION
d263462
@fulghum
Various fixes to support dumping binlog events from a primary server:…
241e512 
… exposing a function to flush a connection's buffer, adding constructor functions for more MySQL binlog event types, and fixing incorrect deserialization code.
@fulghum fulghum changed the title Port: Support for COM_REGISTER_REPLICA Updates for binlog primary protocol Mar 25, 2024
zachmu
zachmu approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 65f4774 into main Mar 25, 2024
This was referenced Mar 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fulghum @zachmu