Skip to content

supports FROM s.account, in which account is non-reserved keyword#313

Merged
jycor merged 1 commit intodolthub:mainfrom
boyxuper:main
Feb 28, 2024
Merged

supports FROM s.account, in which account is non-reserved keyword#313
jycor merged 1 commit intodolthub:mainfrom
boyxuper:main

Conversation

@boyxuper
Copy link

No description provided.

@boyxuper boyxuper requested a review from zachmu as a code owner February 27, 2024 02:31
@boyxuper
Copy link
Author

boyxuper commented Feb 28, 2024

Hi, I just re-generated sql.go with goyacc v0.1.9, please rerun checks.
However, the latest version of golang.org/x/tools is v0.18.0, should it be upgraded?

@zachmu
Copy link
Member

zachmu commented Feb 28, 2024

Looks fine to me, @jycor can you validate?

@zachmu zachmu requested a review from jycor February 28, 2024 18:21
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants