Added a way for Doltgres to inject expressions#309
Merged
Hydrocharged merged 2 commits intomainfrom Feb 7, 2024
Merged
Conversation
max-hoffman
reviewed
Feb 6, 2024
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
I'm a bit worried about this skipping a phase of semantic resolution in ways that might be inconvenient if you end up needing those phases of semantic resolution. The way we do things like this in the engine right now is to make an interface with some dummy method that hooks into an extra lifecycle step. Postgres specific name for an expression seems unusual when it could be generic without loss of generality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily adds a new AST node that DoltgreSQL takes advantage of. All currently-existing nodes are specifically designed for MySQL transformations. In many cases, Doltgres will have different transformations that need to take place, and this provides a way for Doltgres to implement those transformations without having to modify other packages whenever a new transformation is added or edited.
Related PRs: