Allow UNIQUE and PRIMARY KEY to be specified on the same column#305
Merged
Allow UNIQUE and PRIMARY KEY to be specified on the same column#305
UNIQUE and PRIMARY KEY to be specified on the same column#305Conversation
…KEY, in addition to UNIQUE
jycor
approved these changes
Jan 23, 2024
jycor
left a comment
There was a problem hiding this comment.
LGTM!
It seems like MySQL also allows multiple unique keys to be defined over the same column(s), and just ignores the duplicates
Not sure if it's worth adding in this PR though.
mysql> create table t (id int unique key unique key);
Query OK, 0 rows affected (0.0259 sec)
mysql> show create table t;
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+
| t | CREATE TABLE `t` (
`id` int DEFAULT NULL,
UNIQUE KEY `id` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.0012 sec)
Author
|
whoa... good find on the duplicate key options! Very weird that MySQL allows that. I'll go ahead and add support for that while I'm in here since it's only a couple more lines of code and some new test statements. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: dolthub/dolt#7395