Skip to content

Add additional types to sqlparser.SQLType()#293

Merged
nicktobey merged 2 commits intomainfrom
nicktobey/sql
Dec 4, 2023
Merged

Add additional types to sqlparser.SQLType()#293
nicktobey merged 2 commits intomainfrom
nicktobey/sql

Conversation

@nicktobey
Copy link
Copy Markdown

@nicktobey nicktobey commented Dec 1, 2023

This function is used when the parser needs to map type names to underlying types in order to judge the validity of certain queries. Some types are aliases for others, (like REAL is an alias for float64) but they weren't included in SQLType(), so certain expressions that used these types could panic.

@nicktobey nicktobey requested a review from zachmu as a code owner December 1, 2023 23:37
@nicktobey nicktobey changed the title Add REAL, DEC, and FIXED to sqlparser.SQLType() Add additional types to sqlparser.SQLType() Dec 2, 2023
@nicktobey nicktobey requested a review from jycor December 2, 2023 01:12
Copy link
Copy Markdown

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit 0ed804e into main Dec 4, 2023
@nicktobey nicktobey deleted the nicktobey/sql branch December 4, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants