Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/analyzer: aliases.go: Make sure we add the right table alias when traversing a DecoratedNode. #559

Merged
merged 3 commits into from
Sep 21, 2021
Merged

sql/analyzer: aliases.go: Make sure we add the right table alias when traversing a DecoratedNode. #559

merged 3 commits into from
Sep 21, 2021

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Sep 20, 2021

No description provided.

zachmu
zachmu reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test, but looks good otherwise

zachmu
zachmu approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit e83ad3b into master Sep 21, 2021
@Hydrocharged Hydrocharged deleted the aaron/analyzer-table-alias-decorated-node branch December 8, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @zachmu