Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/plan: {update,delete}.go: Correctly return an error for unsupported UPDATEs and DELETEs against joins and subqueries. #485

Merged
merged 1 commit into from
Jun 30, 2021
Merged

sql/plan: {update,delete}.go: Correctly return an error for unsupported UPDATEs and DELETEs against joins and subqueries. #485

merged 1 commit into from
Jun 30, 2021

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jun 28, 2021

No description provided.

@reltuk
sql/plan: {update,delete}.go: Correctly return an error for unsupport…
96bc57a 
…ed UPDATEs and DELETEs against joins and subqueries.
@reltuk reltuk requested a review from zachmu June 28, 2021 21:25
zachmu
zachmu approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit e7ea534 into master Jun 30, 2021
@Hydrocharged Hydrocharged deleted the aaron/err-on-currently-unsupported-update-and-delete-targets branch December 8, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @zachmu