Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added statement boundaries #429

Merged
merged 1 commit into from
May 27, 2021
Merged

Added statement boundaries #429

merged 1 commit into from
May 27, 2021

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

@Hydrocharged Hydrocharged force-pushed the daylon/statement-boundary branch 2 times, most recently from d3ef9bb to e3d3c6c Compare May 25, 2021 10:04
@Hydrocharged Hydrocharged mentioned this pull request May 25, 2021
Merged
zachmu
zachmu approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly naming changes, generally looks good

Need some engine tests for this functionality, which you may need to skip on the memory engine for now

sql/core.go Outdated Show resolved Hide resolved
sql/core.go Outdated Show resolved Hide resolved
sql/core.go Outdated Show resolved Hide resolved
sql/plan/statement_boundary.go Outdated Show resolved Hide resolved
sql/system_variables.go Outdated Show resolved Hide resolved
sql/core.go Outdated Show resolved Hide resolved
memory/table.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged force-pushed the daylon/statement-boundary branch from e3d3c6c to 021abaf Compare May 27, 2021 22:19
@Hydrocharged Hydrocharged merged commit 899e18d into master May 27, 2021
@Hydrocharged Hydrocharged deleted the daylon/statement-boundary branch May 27, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu