Skip to content

Get index column name using offset from table name prefix length#3436

Merged
angelamayxie merged 4 commits intomainfrom
angela/indexExprCols
Feb 19, 2026
Merged

Get index column name using offset from table name prefix length#3436
angelamayxie merged 4 commits intomainfrom
angela/indexExprCols

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

fixes dolthub/dolt#10527

Using the index of the first found . rune as an offset to get an index column name was causing column names to not be correctly matched when the table name contained periods. Using the length of the table name as an offset avoids this issue and is also slightly more performant.

@angelamayxie angelamayxie marked this pull request as ready for review February 19, 2026 00:20
@angelamayxie angelamayxie requested a review from jycor February 19, 2026 00:20
Copy link
Copy Markdown
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelamayxie angelamayxie merged commit 975a728 into main Feb 19, 2026
8 checks passed
@angelamayxie angelamayxie deleted the angela/indexExprCols branch February 19, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Index Lookup Corruption for Tables with Dots in Names During Joins

2 participants