Do not join remaining tables with CrossJoins during buildSingleLookupPlan#3417
Merged
angelamayxie merged 4 commits intomainfrom Feb 5, 2026
Merged
Do not join remaining tables with CrossJoins during buildSingleLookupPlan#3417angelamayxie merged 4 commits intomainfrom
angelamayxie merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10304
Despite what the comment said, it's not safe to join remaining tables with CrossJoins during
buildSingleLookupPlan. It is only safe to do so if every filter has been successfully matched tocurrentlyJoinedTables. Otherwise, we end up dropping filters.For example, we could have a query like
select from A, B, inner join C on B.c0 <=> C.c0where table A has a primary key and tables B and C are keyless.columnKeymatches A's primary key column and A would be added tocurrentlyJoinedTables. Since the only filter references B and C and neither are part ofcurrentlyJoinedTabes, nothing is ever added tojoinCandidates. However, it's unsafe to join all the tables with CrossJoins because we still need to account for the filter on B and C.