Calculate month and quarter for timestampdiff based on date and clock time values#3409
Merged
angelamayxie merged 8 commits intomainfrom Feb 2, 2026
Merged
Calculate month and quarter for timestampdiff based on date and clock time values#3409angelamayxie merged 8 commits intomainfrom
month and quarter for timestampdiff based on date and clock time values#3409angelamayxie merged 8 commits intomainfrom
Conversation
jycor
approved these changes
Feb 2, 2026
Contributor
jycor
left a comment
jycor
left a comment
There was a problem hiding this comment.
LGTM, consider separating helper function.
| { | ||
| // https://github.com/dolthub/dolt/issues/10397 | ||
| Skip: true, | ||
| // might need to change first date to 0001-01-01 since 0000 is a leap year in Go but not in MySQL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10393
Refactors logic for
yearinto separate functionmonthDiffso that it can be reused formonthandquarter