Skip to content

avoid converting float64 to float64#3396

Merged
jycor merged 5 commits intomainfrom
james/sum
Jan 26, 2026
Merged

avoid converting float64 to float64#3396
jycor merged 5 commits intomainfrom
james/sum

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Jan 23, 2026

We save on conversion costs by avoiding a call to convert float64 to float64.
Unfortunately this has little to no impact on any of our benchmarks because groupbyIter uses concurrency.

benchmarks: dolthub/dolt#10359 (comment)

Copy link
Copy Markdown
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jycor jycor merged commit 021abaf into main Jan 26, 2026
8 checks passed
@jycor jycor deleted the james/sum branch January 26, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants