Skip to content

fewer strings.ToLower calls in gatherTableAlias #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycor merged 2 commits into from
Jan 22, 2026
Merged

fewer strings.ToLower calls in gatherTableAlias #3395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7218b5
reduce ToLower and string allocs in gatherTableAlias
Jan 22, 2026
df9d183
less tolower
Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions sql/analyzer/symbol_resolution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ func pruneTableCols(
cols := make([]string, 0)
source := strings.ToLower(table.Name())
for _, col := range table.Schema() {
c := newTableCol(source, col.Name)
c := tableCol{
table: source,
col: strings.ToLower(col.Name),
}
if parentCols[c] > 0 {
cols = append(cols, c.col)
}
Expand Down Expand Up @@ -310,26 +313,32 @@ func gatherTableAlias(
alias := strings.ToLower(n.Name())
var base string
if rt, ok := n.Child.(*plan.ResolvedTable); ok {
base = rt.Name()
base = rt.Name() // TODO: toLower?
}
_, starred := parentStars[alias]
if starred {
nodeStars = append(nodeStars, base)
}
if unqualifiedStar {
starred = true
}
base = strings.ToLower(base)
for _, col := range n.Schema() {
baseCol := newTableCol(base, col.Name)
aliasCol := newTableCol(alias, col.Name)
colName := strings.ToLower(col.Name)
aliasCol := tableCol{
table: alias,
col: colName,
}
if starred || parentCols[aliasCol] > 0 {
// if the outer scope requests an aliased column
// a table lower in the tree must provide the source
baseCol := tableCol{
table: base,
col: colName,
}
cols = append(cols, baseCol)
}
}
for t := range parentStars {
if t == alias {
nodeStars = append(nodeStars, base)
}
}
return cols, nodeStars
default:
}
Expand Down