Skip to content

Add IsExpr case to replaceVariablesInExpr #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelamayxie merged 1 commit into from
Jan 9, 2026
Merged

Add IsExpr case to replaceVariablesInExpr #3376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions enginetest/queries/procedure_queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,6 +2407,23 @@ CREATE PROCEDURE test()
},
},
},
{
Name: "Resolve procedure variable in IS expression",
SetUpScript: []string{
`CREATE PROCEDURE p1(IN v TEXT)
BEGIN
DECLARE v_text TEXT;
SET v_text = v;
select v_text is null;
END`,
},
Assertions: []ScriptTestAssertion{
{
Query: "call p1('abc')",
Expected: []sql.Row{{false}},
},
},
},
}

var ProcedureCallTests = []ScriptTest{
Expand Down
6 changes: 6 additions & 0 deletions sql/procedures/interpreter_logic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ func replaceVariablesInExpr(ctx *sql.Context, stack *InterpreterStack, expr ast.
return nil, err
}
e.Expr = newExpr.(ast.Expr)
case *ast.IsExpr:
newExpr, err := replaceVariablesInExpr(ctx, stack, e.Expr, asOf)
if err != nil {
return nil, err
}
e.Expr = newExpr.(ast.Expr)
case *ast.ExistsExpr:
newSubquery, err := replaceVariablesInExpr(ctx, stack, e.Subquery, asOf)
if err != nil {
Expand Down