Merged
Conversation
Hydrocharged
force-pushed
the
daylon/distinct-on
branch
2 times, most recently
from
7910621 to
de9eccc
Compare
This was referenced Jan 8, 2026
zachmu
reviewed
Jan 8, 2026
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
Overall implementation seems very reasonable but I think the builder stuff probably misses important cases which make it not work for some queries. Since the tests for this are all in Doltgres, add test cases there. Try to construct queries with very different node plans, give this some more attention.
Hydrocharged
force-pushed
the
daylon/distinct-on
branch
from
de9eccc to
f8f9f51
Compare
Hydrocharged
force-pushed
the
daylon/distinct-on
branch
from
f8f9f51 to
fec6cc6
Compare
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: