Merged
Conversation
Hydrocharged
approved these changes
Jan 7, 2026
Contributor
Hydrocharged
left a comment
Hydrocharged
left a comment
There was a problem hiding this comment.
LGTM, although this feels quite hacky with an easy fix
sql/rowexec/ddl.go
Outdated
Comment on lines
+888
to
+891
| // If no database is selected, first try to fall back to CREATE DATABASE | ||
| // since CREATE SCHEMA is a synonym for CREATE DATABASE in MySQL | ||
| // https://dev.mysql.com/doc/refman/8.4/en/create-database.html | ||
| // TODO: For PostgreSQL, return an error if no database is selected. |
Contributor
There was a problem hiding this comment.
This seems way too hacky. It makes way more sense to just have MySQL resolve to only "CREATE DATABASE" and "DROP DATABASE" since "SCHEMA" is strictly a synonym for them. That way, when we see "SCHEMA", then it must come from Doltgres and we don't have to worry about it. Or even call it a "NAMESPACE" instead just to be more distinct with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.