Skip to content

Handle more types in abs#3365

Merged
angelamayxie merged 4 commits intomainfrom
angela/abs
Jan 6, 2026
Merged

Handle more types in abs#3365
angelamayxie merged 4 commits intomainfrom
angela/abs

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

fixes dolthub/dolt#10171
fixes dolthub/dolt#10270

Add case for bool types and add default case that tries to convert value to Float64.

@angelamayxie angelamayxie marked this pull request as ready for review January 6, 2026 20:49
@angelamayxie angelamayxie requested a review from jycor January 6, 2026 20:49
Copy link
Copy Markdown
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing suggestions

@angelamayxie angelamayxie merged commit 877fb58 into main Jan 6, 2026
8 checks passed
@angelamayxie angelamayxie deleted the angela/abs branch January 6, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

abs returns null when inputs are boolean values abs does not truncate strings

2 participants