Skip to content

Handle empty right iterators in exists iterator as an EOF#3361

Merged
angelamayxie merged 5 commits intomainfrom
angela/remove_nullrejecting
Jan 5, 2026
Merged

Handle empty right iterators in exists iterator as an EOF#3361
angelamayxie merged 5 commits intomainfrom
angela/remove_nullrejecting

Conversation

@angelamayxie
Copy link
Copy Markdown
Contributor

@angelamayxie angelamayxie commented Jan 3, 2026

fixes dolthub/dolt#10258

An empty right iterator in an exists iterator should be treated the same as an EOF. Previously, we were treating an empty right iterator as if it would be returning a single nil row, but this is wrong. An empty right iterator would imply an empty set, which is not the same as a single nil row.

@angelamayxie angelamayxie changed the title Remove check for nullRejecting filter in exists iterator Handle right iterators in exists iterator as an EOF Jan 3, 2026
@angelamayxie angelamayxie changed the title Handle right iterators in exists iterator as an EOF Handle empty right iterators in exists iterator as an EOF Jan 3, 2026
@angelamayxie angelamayxie marked this pull request as ready for review January 5, 2026 18:17
@angelamayxie angelamayxie requested a review from jycor January 5, 2026 18:44
Copy link
Copy Markdown
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelamayxie angelamayxie merged commit 6ee876e into main Jan 5, 2026
8 checks passed
@angelamayxie angelamayxie deleted the angela/remove_nullrejecting branch January 5, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WHERE NOT EXISTS from an empty view does not return correct results

2 participants