Return boolean literal when simplifying AND and OR filters#3356
Merged
angelamayxie merged 4 commits intomainfrom Dec 26, 2025
Merged
Return boolean literal when simplifying AND and OR filters#3356angelamayxie merged 4 commits intomainfrom
AND and OR filters#3356angelamayxie merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10243
Previously, if one of the children of an
ANDorORexpression was a literal that evaluated tofalseortrue(respectively), we would return the child. However, this caused a typing issue sinceANDandORare booleans while its children can be of any type. Take the expression19 or 's'for example; the left child19evaluates totrue, making the expression true every time, but returning the left child19as a simplification would be incorrect since we would want the expression to simplify to a booleantrue, not the number 19.Now, instead of returning the child that determines the result of an
ANDorORexpression, we return the boolean value that the expression results to.