Do not use nullable columns as null filter when converting antijoins to left joins#3355
Merged
angelamayxie merged 4 commits intomainfrom Dec 23, 2025
Merged
Do not use nullable columns as null filter when converting antijoins to left joins#3355angelamayxie merged 4 commits intomainfrom
angelamayxie merged 4 commits intomainfrom
Conversation
jycor
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10234
When converting an antijoin to a left join, it is normally okay to use a nullable GetField in a null filter. However, we cannot do so if GetField is both nullable and part of an OR expression. There's currently no way of identifying an expression's parent during InspectExpr so we have to be extra safe by not allowing nullable GetFields in null filters at all.