various analyzer and planbuilder optimizations#3345
Merged
Conversation
zachmu
approved these changes
Dec 16, 2025
| if i64, err := strconv.ParseInt(value, base, 64); err == nil { | ||
| return expression.NewLiteral(int64(i64), types.Int64) | ||
| func (b *Builder) convertInt(value []byte, base int) *expression.Literal { | ||
| valStr := encodings.BytesToString(value) |
Member
There was a problem hiding this comment.
Should write a comment about what the below logic is doing and that it's for perf reasons
sql/planbuilder/scalar_test.go
Outdated
| if ok { | ||
| return nil, SameTree, stopInspect | ||
| func InspectExpr(expr sql.Expression, f func(sql.Expression) bool) bool { | ||
| children := expr.Children() |
Member
There was a problem hiding this comment.
Kinda can't believe we were doing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
convertIntto call strings library fewer timesInspectExpr()isEvaluableinto single passSprintfwith simple string concatenationiScanAndcount children as they are addedbenchmarks: dolthub/dolt#10210 (comment)