Set SubqueryAlias.OuterScopeVisibility to true if inside trigger scope#3342
Merged
angelamayxie merged 4 commits intomainfrom Dec 12, 2025
Merged
Set SubqueryAlias.OuterScopeVisibility to true if inside trigger scope#3342angelamayxie merged 4 commits intomainfrom
SubqueryAlias.OuterScopeVisibility to true if inside trigger scope#3342angelamayxie merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#10175
Trigger scopes were being included when determining exec indexes for
SubqueryAliaschild nodes but were not actually passed down to child iterators during rowexec (code). As a result, we were getting index out of bounds errors since the trigger scopes were not included in the parent row.Since there's no easy way to separate the trigger scope columns out from the rest of the parent row during rowexec, it was easier to just mark
SubqueryAlias.OuterScopeVisibilityinside triggers to true. I think it technically does make sense here because the trigger scope is an outer scope that theSubqueryAliasdoes have visibility of, but I added a TODO comment in case this is incorrect.