sql/analyzer: join_search: Update indexed join search to respect structural requirements on left and right joins. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctural requirements on left and right joins. Only commute join nodes when they are actually safe to commute.
…-search-commute-only-when-safe
…ithin subqueries when query scope is non-empty.
zachmu
approved these changes
Mar 12, 2021
sql/analyzer/indexed_joins.go
Outdated
| // set in `commutes`, and a left or right join gets a node with a | ||
| // `left` and a `right` child. original on the left and the new table | ||
| // being joined on the right. | ||
| func newJoinOrderNode(node sql.Node) *joinOrderNode { |
There was a problem hiding this comment.
Probably belongs in join_search.go
| @@ -21,12 +21,13 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
|
|
|||
| "github.com/dolthub/go-mysql-server/sql" | |||
| "github.com/dolthub/go-mysql-server/sql/plan" | |||
| ) | |||
|
|
|||
| func TestBuildJoinTree(t *testing.T) { | |||
There was a problem hiding this comment.
Need some new test cases that exercise the left and right join table ordering semantics you added
sql/analyzer/join_search.go
Outdated
|
|
||
| // applyJoinHint will set the `jo.order` fields of the root node and | ||
| // the internal nodes of the joinOrderNode to the order in the | ||
| // provided `hint`, presuming that order to valid. If it is not valid, |
…des with left and right children.
…ressions
sql/{plan,analyzer}: {join,indexed_join}: Update join logic to work within subqueries when query scope is non-empty.
Hydrocharged
deleted the
aaron/analyzer-join-search-commute-only-when-safe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only commute join nodes when they are actually safe to commute.