Skip to content

dolthub/go-mysql-server#3144 - Fix parseErr tracing to show error messages instead of memory addresses#3147

Merged
elianddb merged 2 commits intomainfrom
elianddb/3144-fix-trace-parse-exceptions
Aug 7, 2025
Merged

dolthub/go-mysql-server#3144 - Fix parseErr tracing to show error messages instead of memory addresses#3147
elianddb merged 2 commits intomainfrom
elianddb/3144-fix-trace-parse-exceptions

Conversation

@elianddb
Copy link
Copy Markdown
Contributor

@elianddb elianddb commented Aug 6, 2025

Fixes #3144
Add Error() method to parseErr struct so tracing systems show actual error messages instead of memory addresses like "{0xc006f85d80}".

Copy link
Copy Markdown
Contributor

@kylebrandt kylebrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine :-)

image

Thank you!

Copy link
Copy Markdown
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elianddb elianddb merged commit c76b4ab into main Aug 7, 2025
8 checks passed
@Hydrocharged Hydrocharged deleted the elianddb/3144-fix-trace-parse-exceptions branch December 17, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Planbuilder: Traces do not record parse exceptions correctly

3 participants