Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added INOUT/OUT params to procedures & nested procedures #312

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Feb 23, 2021

Stored procedures now work with INOUT/OUT directions for their parameters. Not only is this critical for nested CALL statements to work properly, but additional changes were made to handle nested CALLs. Stored procedures are now loaded before analyzing the query body.

@Hydrocharged Hydrocharged requested a review from zachmu February 23, 2021 13:39
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but I definitely don't like the ProcedureRegistry construct, or how it's initialized manually. Make the caching happen in the ctx or the analzyer itself, and make it implicitly load when needed. Otherwise LGTM!

enginetest/procedure_queries.go Show resolved Hide resolved
engine.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged force-pushed the daylon/stored-procedures-2 branch from 66ed061 to 8f8f761 Compare February 25, 2021 10:34
@Hydrocharged Hydrocharged force-pushed the daylon/stored-procedures-2 branch from 8f8f761 to f721f9a Compare February 25, 2021 10:38
@Hydrocharged Hydrocharged merged commit 401523d into master Feb 25, 2021
@Hydrocharged Hydrocharged deleted the daylon/stored-procedures-2 branch February 25, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants