Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max/float53 #309

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Max/float53 #309

merged 3 commits into from
Feb 22, 2021

Conversation

max-hoffman
Copy link
Contributor

Follow specific rules for mysql float/double/error depending on the float ops.

Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few small comments and it's ready to merge!

sql/errors.go Outdated Show resolved Hide resolved
sql/type.go Outdated Show resolved Hide resolved
sql/errors.go Outdated Show resolved Hide resolved
@max-hoffman max-hoffman merged commit d01ff67 into master Feb 22, 2021
@max-hoffman max-hoffman deleted the max/float53 branch February 22, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants