Skip to content

backtick column names in check constraints#3040

Merged
jycor merged 6 commits intomainfrom
james/check
Jun 24, 2025
Merged

backtick column names in check constraints#3040
jycor merged 6 commits intomainfrom
james/check

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Jun 23, 2025

MySQL backticks any column names within a check expression preventing any parser errors when round tripping tables, so we should do the same.

fixes: dolthub/dolt#9343

@jycor jycor changed the title escape column names in check constraints backtick column names in check constraints Jun 23, 2025
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit cf1535b into main Jun 24, 2025
7 of 8 checks passed
@jycor jycor deleted the james/check branch June 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check constraint with column named order breaks inserts, updates, other operations

2 participants