Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of adding support for
IS NULLandIS NOT NULLimplementations that can match Postgres's behavior for records, I've been digging through the references toexpression.IsNullin GMS so that we can have a separate implementation for Doltgres that GMS can still analyze correctly.One reference to
expression.IsNullis in thehasSingleOutputwhich is used to determine if an expression result has a single row or more than one row. The only expression implementation I was able to find that actually returns multiple rows isplan.Subquery, so I simplified this function to remove the reference toexpression.IsNull.