Properly escape special characters in comments#2997
Merged
angelamayxie merged 7 commits intomainfrom May 29, 2025
Merged
Conversation
a6e6050 to
5b482ea
Compare
jycor
approved these changes
May 29, 2025
Contributor
jycor
left a comment
There was a problem hiding this comment.
LGTM!
Add some ALTER TABLE tests in gms/enginetest/queries/alter_table_queries.go
Something like
{
Name: "alter table comments are also escaped",
SetUpScript: []string{
"create table t (i int);",
`alter table t modify column i int comment ...`,
`alter table t add column j int comment ...`,
},
Assertions: []ScriptTestAssertion{
{
Query: "show create table t",
Expected: []sql.Row{
{...},
},
},
},
},
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly fixes dolthub/dolt#8509 (does not handle Control+Z)