Skip to content

prevent panics in replacePkSort#2916

Merged
jycor merged 1 commit intomainfrom
james/replace
Mar 27, 2025
Merged

prevent panics in replacePkSort#2916
jycor merged 1 commit intomainfrom
james/replace

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Mar 27, 2025

Not sure how to reproduce this, but this should make the code more safe.

fixes: #2915

Copy link
Copy Markdown
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jycor jycor merged commit fead863 into main Mar 27, 2025
9 checks passed
@kylebrandt
Copy link
Copy Markdown
Contributor

When I switch to using main I'm not longer getting the panic in the case I was before -- thank you.

@Hydrocharged Hydrocharged deleted the james/replace branch December 17, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic when calling min/max (without a Primary Key?)

3 participants