Skip to content

special case for unix_timestamp#2907

Merged
jycor merged 11 commits intomainfrom
james/unix
Mar 24, 2025
Merged

special case for unix_timestamp#2907
jycor merged 11 commits intomainfrom
james/unix

Conversation

@jycor
Copy link
Copy Markdown
Contributor

@jycor jycor commented Mar 24, 2025

When the provided timestamp is in string format, we preserve the scale of the original string (assuming it is valid).
Additionally, we should round precision instead of truncating.

dolthub/dolt#9025

Copy link
Copy Markdown
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jycor jycor merged commit ddeab07 into main Mar 24, 2025
8 checks passed
@jycor jycor deleted the james/unix branch March 24, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants