Skip to content

Clean up regex.Regex disposal #2900

Merged
fulghum merged 2 commits intomainfrom
fulghum/regex
Mar 19, 2025
Merged

Clean up regex.Regex disposal #2900
fulghum merged 2 commits intomainfrom
fulghum/regex

Conversation

@fulghum
Copy link
Copy Markdown
Contributor

@fulghum fulghum commented Mar 19, 2025

Preserves Regex instances when creating new nodes from WithChildren() for RegexpInstr , RegexpLike, and RegexpSubstr instances. Disables panics when detecting a leaked Regex and installs a custom function to log an error.

Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 8c915e5 into main Mar 19, 2025
8 checks passed
@fulghum fulghum deleted the fulghum/regex branch March 19, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants