[memo] hash join right-side cardinality can be filtered#2899
Merged
max-hoffman merged 2 commits intomainfrom Mar 20, 2025
Merged
[memo] hash join right-side cardinality can be filtered#2899max-hoffman merged 2 commits intomainfrom
max-hoffman merged 2 commits intomainfrom
Conversation
fulghum
approved these changes
Mar 19, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks good. The comment on line 97 looks out of date now based on the PR description.
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously assumed HASH_JOIN would load whole right table into memory. This overestimates the cost, we only read and cache the indexed fraction.
perf benchmarks: dolthub/dolt#9007