allow before insert trigger to specify missing column, but better#2883
Merged
allow before insert trigger to specify missing column, but better#2883
Conversation
max-hoffman
approved these changes
Mar 10, 2025
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
looks good, just a naming/impl comment
sql/plan/insert.go
Outdated
| FirstGeneratedAutoIncRowIdx int | ||
|
|
||
| // MissingValFlags marks which columns in the destination schema are expected to have default values. | ||
| MissingValFlags []bool |
Contributor
There was a problem hiding this comment.
could maybe pick a more specific name?deferredDefaults, delayedDefaults, delayedNonNulls
Contributor
There was a problem hiding this comment.
i'd maybe make this a sql.FastIntSet also, rather than an array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that a
BEFORE INSERT TRIGGERfills in the values for a column when it is otherwise missing. This should not trigger a missing default value error.Fixes: dolthub/dolt#8926
This PR is an improvement on: #2876