Skip to content

Fix alter table panics#2866

Merged
max-hoffman merged 1 commit intomainfrom
max/alter-table-panic
Mar 3, 2025
Merged

Fix alter table panics#2866
max-hoffman merged 1 commit intomainfrom
max/alter-table-panic

Conversation

@max-hoffman
Copy link
Copy Markdown
Contributor

Multi-alters are executed with Block iterators. Block error handling always assumed the calling context was a stored procedure, which doesn't appear to be true in this case. Rather than create a new iterator, error handling noops to the default error if a proc reference is not found.

fixes: dolthub/dolt#8917

Copy link
Copy Markdown
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit a98abd7 into main Mar 3, 2025
9 checks passed
@max-hoffman max-hoffman deleted the max/alter-table-panic branch March 3, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGSEGV panic when modifying the schema for foreign keys

2 participants