Conversation
…oIncrement but don't support writing it.
zachmu
approved these changes
Mar 1, 2025
| // AutoIncrementGetter provides support for reading a table's AUTO_INCREMENT value. | ||
| // This can include tables that don't implement AutoIncrementTable if the table is a read-only snapshot | ||
| // of an auto-incremented table. | ||
| type AutoIncrementGetter interface { |
Member
There was a problem hiding this comment.
Please embed this in the AutoIncrementTable interface to make the relationship clearer
| // This can include tables that don't implement AutoIncrementTable if the table is a read-only snapshot | ||
| // of an auto-incremented table. | ||
| type AutoIncrementGetter interface { | ||
| PeekNextAutoIncrementValue(ctx *Context) (uint64, error) |
Member
There was a problem hiding this comment.
Also move the method doc from AutoIncrementTable.Peek to here
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the GMS side of an issue to properly display diffs when the autoincrement counter on a table changes.
We add a new interface,
AutoIncrementGetterfor tables that store AutoIncrement info, even if they can't generate autoincremented ids (because they're immutable snapshots of a table with an autoincrement column)