Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabling read-comitted #2733

Merged
merged 3 commits into from
Nov 5, 2024
Merged

disabling read-comitted #2733

merged 3 commits into from
Nov 5, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 5, 2024

No description provided.

@jycor jycor mentioned this pull request Nov 5, 2024
Merged
zachmu
zachmu reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather remove the logic that reads this value than just disabling it here

zachmu
zachmu approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit e48937b into main Nov 5, 2024
8 checks passed
@jycor jycor deleted the james/save branch November 5, 2024 22:08
@BrewTestBot BrewTestBot mentioned this pull request Nov 6, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @zachmu