Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move applyEventScheduler logic and eventscheduler to builder #2729

Merged
merged 10 commits into from
Nov 1, 2024
Merged

move applyEventScheduler logic and eventscheduler to builder #2729

merged 10 commits into from
Nov 1, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 31, 2024

No description provided.

@jycor jycor mentioned this pull request Nov 1, 2024
Merged
max-hoffman
max-hoffman approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would have maybe put EventScheduler on the Catalog

@jycor jycor merged commit 2766041 into main Nov 1, 2024
7 of 8 checks passed
@jycor jycor deleted the james/events branch November 1, 2024 23:01
This was referenced Nov 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman