Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resolveDescribeQuery rule #2726

Merged
merged 2 commits into from
Oct 29, 2024
Merged

remove resolveDescribeQuery rule #2726

merged 2 commits into from
Oct 29, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 29, 2024

This rule just recurses into the analyzer, so we should just do it right at the beginning, so we should do it right away and avoid calling all other rules.

This would be better/cleaner in the planbuilder, but we would need to tell the analyzer to not analyze this node or skip it somehow.

It's possible to move this logic into analyzeWithSelector.
It might be more difficult to move this above Analyze, as we'd have to put this logic in a variety of places.

@jycor jycor changed the title remove resolveDescribeQuery` rule remove resolveDescribeQuery rule Oct 29, 2024
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth actually writing down a few alternatives in the PR description, convince ourselves that this is the safest/most maintainable way to do this. Like why not one level above/below this call point?

@jycor jycor merged commit a6e78e0 into main Oct 29, 2024
8 checks passed
@jycor jycor deleted the james/describe branch October 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants