Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove plan.QueryProcess and move logic to finalizeIters #2714

Merged
merged 8 commits into from
Oct 23, 2024
Merged

remove plan.QueryProcess and move logic to finalizeIters #2714

merged 8 commits into from
Oct 23, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 23, 2024 •
edited
Loading

This PR removes the use of plan.QueryProcess and part of the trackProcess rule that adds/removes this node.
Instead the TrackedRowIter is created directly in finalizeIters.

@jycor jycor changed the title remove query process remove plan.QueryProcess and move logic to finalizeIters Oct 23, 2024
@jycor jycor mentioned this pull request Oct 23, 2024
Merged
max-hoffman
max-hoffman approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the one meta thing to consider is if we can have finalizeIters not depend on plan nodes at some point

@jycor jycor merged commit ef9faa3 into main Oct 23, 2024
7 of 8 checks passed
@jycor jycor deleted the james/queryprocess branch October 23, 2024 21:09
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman