Skip to content

Bug fix: Set non-boolean system variable enum values to 'ON' or 'OFF' #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2024
Merged

Bug fix: Set non-boolean system variable enum values to 'ON' or 'OFF' #2394

merged 2 commits into from
Mar 14, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Mar 14, 2024

We were automatically converting ON and OFF values to to true and false when setting a system variable, which made it impossible to set system variables to those enum values. For example:

SET @@GLOBAL.gtid_mode='ON';
Variable 'gtid_mode' can't be set to the value of 'true'

jycor
jycor reviewed Mar 14, 2024
View reviewed changes
jycor
jycor approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 0c134fd into main Mar 14, 2024
7 checks passed
@fulghum fulghum deleted the fulghum/bugfix branch March 14, 2024 18:38
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulghum @jycor