Conversation
nicktobey
approved these changes
Mar 11, 2024
| }, | ||
| }, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
Can we also add cast tests like:
select * from vt where v < cast('def' as varchar(6))
etc.
Contributor
Author
There was a problem hiding this comment.
I can't cast to varchar, but I can do char(6); will add these!
Contributor
There was a problem hiding this comment.
Awesome! Are there other types we want to consider here too? Binary, text, etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing range lookups, we convert the key to the type of the column.
The conversion throws an error when the key doesn't fit within the type for the index.
The fix is to promote these (only for StringType) so the ranges fit.
There were issues with
type.Promote()for all types.Additionally, there are some inconsistencies with MySQL when performing these checks with NUL characters (
\0). They are skipped tests for now.related dolthub/dolt#7588