[memory] force mutating the editAcc AutoInc because tableEditor is unreliable#2381
Merged
max-hoffman merged 1 commit intomainfrom Mar 11, 2024
Merged
[memory] force mutating the editAcc AutoInc because tableEditor is unreliable#2381max-hoffman merged 1 commit intomainfrom
max-hoffman merged 1 commit intomainfrom
Conversation
zachmu
approved these changes
Mar 11, 2024
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
This looks fine, this was one of the trickiest parts to get working correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't figure a clean way to get the insert editor's edit accumulator and table editor data in sync when a self-referential foreign key initializes the session editor during analysis. So I just forced us to mutate the edit accumulator's auto increment id, which should prevent bugs of the kind we've been seeing. Zach might have a better understanding of how this should work.
fixes: #2369