Skip to content

don't use all caps for engines info table#2371

Merged
jycor merged 2 commits intomainfrom
james/caps
Mar 7, 2024
Merged

don't use all caps for engines info table#2371
jycor merged 2 commits intomainfrom
james/caps

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Mar 7, 2024

Some clients rely on the correct casing of column names
For some reason, the casing is different when performing SHOW ENGINES; vs select * from information_schema.engines;

Fortunately, the way we do SHOW ENGINES; is actually a SELECT ... under the hood.
So the hacky fix is to just use an alias :)

related dolthub/dolt#7574

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful! ✨

@jycor jycor merged commit 95ba9dc into main Mar 7, 2024
@jycor jycor deleted the james/caps branch March 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants