Conversation
jycor
changed the title
JSON_MERGE() syonymJSON_MERGE() and JSON_MERGE_PATCH()
fulghum
approved these changes
Mar 6, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks great! Just one additional test case for null behavior that I think we should cover.
| @@ -0,0 +1,142 @@ | |||
| // Copyright 2022 Dolthub, Inc. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2022 Dolthub, Inc. | |
| // Copyright 2024 Dolthub, Inc. |
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2022 Dolthub, Inc. | |||
| // Copyright 2022=2024 Dolthub, Inc. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2022=2024 Dolthub, Inc. | |
| // Copyright 2022-2024 Dolthub, Inc. |
| "github.com/dolthub/go-mysql-server/sql/types" | ||
| ) | ||
|
|
||
| func TestJSONMergePatch(t *testing.T) { |
Contributor
There was a problem hiding this comment.
The only test case I noticed missing was an object with a key with a null value. Would be good to test the key deletion behavior for json_merge_patch and probably also worth added a test for json_merge_preserve just to assert that keys with null values aren't deleted there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL Docs: